Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: resolve errors encountered when running Lefthook #140

Merged
merged 5 commits into from
Aug 4, 2024

Conversation

P-manBrown
Copy link
Owner

@P-manBrown P-manBrown commented Aug 4, 2024

Summary

To resolve errors occurring when running Lefthook, I will modify the settings for ESLint and Prettier.

Changes

  • Modify ESLint settings
    Since Jest will not be used for a while, I uninstalled eslint-plugin-jest and removed references to eslint-plugin-jest from .eslintrc.js.
    This change resolves ESLint errors when running Lefthook.

  • Modify Prettier settings
    To resolve errors when running Prettier, I modified the plugins section in .prettierrc.js.
    This change resolves Prettier errors when running Lefthook.

Testing

I confirmed that Lefthook's pre-commit works correctly with the following steps:

  1. Make changes to any file and stage them.
  2. Run yarn lefthook run pre-commit in the terminal.
  3. Confirm that no errors occur.

I confirmed that Lefthook's pre-push works correctly with the following steps:

  1. Run yarn lefthook run pre-push in the terminal.
  2. Confirm that no errors occur.

Related Issues (Optional)

None

Notes (Optional)

I referred to the following page for the Prettier settings modification:
Cannot use any prettier plugins with yarn 4 + PnP

@P-manBrown P-manBrown linked an issue Aug 4, 2024 that may be closed by this pull request
2 tasks
@P-manBrown P-manBrown closed this Aug 4, 2024
@P-manBrown P-manBrown reopened this Aug 4, 2024
@P-manBrown P-manBrown merged commit e9ff60b into main Aug 4, 2024
4 checks passed
@P-manBrown P-manBrown deleted the 139-fix-lefthook-error branch August 4, 2024 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: resolve errors encountered when running Lefthook
1 participant