Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Oztechan/CCC#2860] Move common test values to Fakes in order to share #2861

Merged

Conversation

mustafaozhan
Copy link
Member

Description

Resolves #2860

@mustafaozhan mustafaozhan requested a review from a team as a code owner October 14, 2023 10:51
@mustafaozhan mustafaozhan force-pushed the 2860-Move-common-test-values-to-Fakes-in-order-to-share branch from 7dec8be to 4614c97 Compare October 14, 2023 11:19
@codecov
Copy link

codecov bot commented Oct 14, 2023

Codecov Report

Merging #2861 (4614c97) into develop (9b52909) will decrease coverage by 0.28%.
Report is 2 commits behind head on develop.
The diff coverage is 62.75%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2861      +/-   ##
===========================================
- Coverage    71.96%   71.68%   -0.28%     
===========================================
  Files          207      209       +2     
  Lines         5682     5700      +18     
  Branches       487      497      +10     
===========================================
- Hits          4089     4086       -3     
- Misses        1557     1576      +19     
- Partials        36       38       +2     

Impacted file tree graph

Files Coverage Δ
...han/ccc/client/core/persistence/PersistenceTest.kt 96.15% <100.00%> (-0.40%) ⬇️
...ztechan/ccc/client/core/persistence/fakes/Fakes.kt 100.00% <100.00%> (ø)
...sistence/di/ClientCorePersistenceModule.android.kt 0.00% <0.00%> (ø)
.../client/core/persistence/SuspendPersistenceImpl.kt 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

42.7% 42.7% Coverage
0.0% 0.0% Duplication

@codacy-production
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 5eaa8b11 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (5eaa8b1) Report Missing Report Missing Report Missing
Head commit (4614c97) 5865 4133 70.47%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#2861) 32 32 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@mustafaozhan mustafaozhan merged commit d34d14d into develop Oct 15, 2023
14 checks passed
@mustafaozhan mustafaozhan deleted the 2860-Move-common-test-values-to-Fakes-in-order-to-share branch October 15, 2023 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move common test values to Fakes in order to share
1 participant