[Oztechan/CCC#2857] Add Suspension support for multiplatform settings #2859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2859 +/- ##
===========================================
- Coverage 71.96% 71.72% -0.24%
===========================================
Files 207 208 +1
Lines 5682 5701 +19
Branches 487 497 +10
===========================================
Hits 4089 4089
- Misses 1557 1576 +19
Partials 36 36
|
|
Kudos, SonarCloud Quality Gate passed! |
mustafaozhan
deleted the
2857-Add-Suspension-support-for-multiplatform-settings
branch
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
mustafaozhan
added a commit
that referenced
this pull request
Mar 24, 2024
mustafaozhan
added a commit
that referenced
this pull request
Mar 24, 2024
* Revert "[#3253] Clean up Swift code (#3254)" This reverts commit 92ac1b3. * Revert "[#3251] Prevent multiple Api call when base change on click and add test cases (#3252)" This reverts commit 6755d69. * Revert "[#3191] Add Flow Property for lastInput (#3192)" This reverts commit 375da22. * Revert "[#3189] Move to new getBaseFlow logic (#3190)" This reverts commit 4e4efc9 * Revert "[#3185] Remove navigation result logics (#3186)" This reverts commit ba25635. * Revert "[#3183] Remove onBaseChange event (#3184)" This reverts commit 917be17. * Revert "[#3180] Remove ChangeBase Effect (#3181)" This reverts commit 6fab011. * Revert "[#3178] Replace CurrencyChange effect with DismissDialog (#3179)" This reverts commit fc2f955. * Revert "[#3176] Add Flow Property for currentBase (#3177)" This reverts commit dd2bdc5. * Revert "[#3144] Remove Persistence and use DI dispatchers in Coroutine based Persistences (#3145)" This reverts commit c59e1a5. * Revert "[#3141] Move sessionCount to Suspend (#3142)" This reverts commit e2eaa85. * Revert "[#3138] Move premiumEndDate to Suspend (#3140)" This reverts commit bd0f4b9. * Revert "[#2942] Move firstRun to Suspend (#3137)" This reverts commit 2ff3edf. * Revert "[#3128] Move appTheme to Suspend (#3135)" This reverts commit 00c10be. * Revert "[#3122] Move currentBase to Suspend (#3127)" This reverts commit de4de42 * Revert "[#3123] Move precision to Suspend (#3124)" This reverts commit 26af2a1 * Revert "[#3120] Move lastInput to Suspend (#3121)" This reverts commit 9c53434. * Revert "[#3038] Add missing Settings Koin definition for native target (#3039)" This reverts commit 98870c3. * Revert "[#2871] Add error test case for FlowPersistence (#2872)" This reverts commit c1f8711. * Revert "[#2867] Create test for FlowPersistence (#2868)" This reverts commit 47ea4f9 * Revert "[#2865] Create test for SuspendPersistence (#2866)" This reverts commit fdc952c. * Revert "[#2869] Opt-in for ExperimentalSettingsApi (#2870)" This reverts commit ef9f187. * Revert "[#2863] Use relevant settings for persistencs (#2864)" This reverts commit 00696db * Revert "[#2857] Add Suspension support for multiplatform settings (#2859)" This reverts commit 5eaa8b1 * Revert "[#2855] Add Flow support for multiplatform settings (#2856)" This reverts commit 9b52909 * [#2854] Remove experimental multiplatform settings * [#2854] Remove experimental multiplatform settings * [#2854] Remove experimental multiplatform settings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #2857