-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: update Docker dev environment #289
Conversation
eatyourgreens
commented
Nov 18, 2024
- add some more local code directories to the docker dev build.
- update the docs.
docker-compose.dev.yml
Outdated
- ./.material:/app/.material | ||
- ./config:/app/config | ||
- ./components:/app/components | ||
- ./pages:/app/pages | ||
- ./public:/app/public | ||
- ./styles:/app/styles |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I've got all the places that you might want to make changes while working on the app, but I could be wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there are a few more (lib, scripts, config, docs, ...). Perhaps you could map the entire root dir to /app/
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure about directories like docs, because they aren't used by the running Next.js app.
It might be worth adding a docs service to the compose file, though, so you could see the Next.js app on one port, and the docs site on another.
I'm also wondering whether to add a CLI shell so that people can run yarn scripts inside a container. At the moment, you can't easily run the tests in Docker.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just tried running the tests in a container, and they failed with missing dependency errors. That's a problem for another day.
docker compose -f docker-compose.dev.yml run --rm gutenberg yarn e2e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lib
would be an important directory to include
docker-compose.dev.yml
Outdated
- ./.material:/app/.material | ||
- ./config:/app/config | ||
- ./components:/app/components | ||
- ./pages:/app/pages | ||
- ./public:/app/public | ||
- ./styles:/app/styles |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there are a few more (lib, scripts, config, docs, ...). Perhaps you could map the entire root dir to /app/
?
- add some more local code directories to the docker dev build. - update the docs.
87ce564
to
bc6af30
Compare
I can build and run this locally, from a clean install of the Gutenburg repo. When I make changes in VS Code, I see them reflected in the dev site on http://localhost:3000. I think this will work to get the ICR team up and running with Gutenberg on Windows at tomorrow's hackathon. |
c977fae
to
56939a8
Compare