Adds option to disable search #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alasdairwilson
force-pushed
the
disabe-search
branch
from
cc3e2ca to
e16705f
Compare
martinjrobins
requested changes
Jan 15, 2024
| @@ -0,0 +1 @@ | |||
| export const enableSearch = process.env.NEXT_PUBLIC_ENABLE_SEARCH === "true" ? true : false | |||
There was a problem hiding this comment.
For my own peace of mind, can we do an explicit check for if NEXT_PUBLIC_ENABLE_SEARCH is defined or not. I'm unsure if undefined === "true" will be true or false!
There was a problem hiding this comment.
I checked and thankfully js isnt insane enough for that to be true, undefined with triple equals is only equal to undefined.
I added the check anyway though.
martinjrobins
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #113 Adds a new env var:
"NEXT_PUBLIC_ENABLE_SEARCH" which, if "true" enables the frontend search dialogue and navbar component.
SET THE FLY SECRETS TO TRUE ON STAGING + PROD BEFORE DEPLOYING