-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V0.0.11 #7
Merged
Merged
V0.0.11 #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OwenYou
reviewed
Jan 14, 2023
OwenYou
reviewed
Jan 14, 2023
OwenYou
reviewed
Jan 14, 2023
OwenYou
reviewed
Jan 14, 2023
OwenYou
requested changes
Jan 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix needed for 23.98/23.976 related problems addressed in the comment.
OwenYou
approved these changes
Jan 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
添加 Add:
__str__
方法,返回DfttTimecode对象的时间码值__str__
method,return timecode value for DfttTimecode objectDfttTimecode单元测试(使用pytest)
Unit test for DfttTimecode (Using pytest)
修改 Modify:
对丢帧的检测条件添加有关23.97/23.976的判定
Add 23.97/23.976FPS to drop frame conditions
+
-
运算符对相加的两个DfttTimecode对象的strict属性进行或运算+
-
operators performs an or operation on the strict property of two DfttTimecode objects that are added together比较运算符,比如
==
>
>=
等,在对两个DfttTimecode对象进行比较的时候会先对两个对象的帧率进行判定,若帧率不同抛出异常Comparison operators, such as
==
,>
,>=
, in the comparison of two DfttTimecode objects will first compare the frame rate of the two objects, if the frame rate is different throw an exceptionprint(self)
将会输出基于类型的时间码字符串print(self)
will output a timecode string修复 BugFix:
timecode_output(self, dest_type, output_part)
中output_part = 3
时错误返回分钟数据的问题Addressed a problem when
output_part = 3
intimecode_output(self, dest_type, output_part)
would return minute value in timecode value