Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix smpte validation to only reject if seconds is '00' #2

Merged
merged 1 commit into from
Sep 17, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dftt_timecode/core.py
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ def _(self, timecode_value, timecode_type='auto', fps=24.0, drop_frame=False, st
frame_index = ff + self.__nominal_fps * (ss + mm * 60 + hh * 3600)
else:
drop_per_min = self.__nominal_fps / 30 * 2
if mm % 10 != 0 and ff in (0, drop_per_min - 1): # 检查是否有DF下不合法的帧号
if mm % 10 != 0 and ss == 0 and ff in (0, drop_per_min - 1): # 检查是否有DF下不合法的帧号
logging.log(40,
'Timecode.__init__.smpte: This timecode is illegal under given params, check your input!')
raise DFTTTimecodeValueError
Expand Down