Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 'DeleteOldObbFiles' method in GooglePlayDownloader. #11

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

MorenoB
Copy link

@MorenoB MorenoB commented Jul 5, 2017

This function will delete any previous older obb version if available on the device.

- This function will delete any previous older obb version if available on the device.
@Over17
Copy link
Owner

Over17 commented Jul 7, 2017

I'd be happy to merge it but looks like the line endings were changed, causing the whole file to be different. This will mess up the history. Could you submit a new/updated pull request without changing the line endings?

Thank you!

@MorenoB
Copy link
Author

MorenoB commented Jul 7, 2017

Sure! I just discarded the line changes and re-commited again. :)

@Over17
Copy link
Owner

Over17 commented Jul 28, 2017

Sorry for the delay!

Your changes don't compile for me - obb_package and obb_version variables don't exist. Can you please address that?

One more thing - a huge update to the plugin is coming very soon, inlcuding converting to .aar and rewritten C# code. Maybe it makes sense to wait until it lands, and create a pull request afterwards?

Thanks!

@Over17
Copy link
Owner

Over17 commented Dec 19, 2017

@MorenoB is this still actual? If so, can you please rebase to the latest revision - I've updated the public API of the plugin. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants