Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move query from command to controller #3705

Open
wants to merge 11 commits into
base: v8/develop
Choose a base branch
from

Conversation

Mihajlo-Pavlovic
Copy link
Collaborator

Description

Move query logic from command to controller so there is no delay introduced by the command executor to query execution.

Old endpoint and command are still in the code for backward compatibility with old clients.

Fixes # (issue)

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Test new endpoint with local network. It is ~40x times faster than old query endpoint when used with dkg.js demo

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Mihajlo-Pavlovic Mihajlo-Pavlovic added improvement Improvements or enhancements to existing features V8 Issue or development of DKG Core Runtime Node V8 labels Feb 2, 2025
@Mihajlo-Pavlovic Mihajlo-Pavlovic self-assigned this Feb 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvements or enhancements to existing features V8 Issue or development of DKG Core Runtime Node V8
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants