[#264] Add component checkbox #447
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
#264) Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
) Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
Tokens library version v0.5.0 Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
pylapp
force-pushed
the
264-add-component-checkbox-4
branch
from
9fe0d4b to
3eb7f25
Compare
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
ludovic35
requested changes
Feb 6, 2025
|
|
||
| // MARK: - Checkbox Configuration Model | ||
|
|
||
| /// The model shared between `CheckboxPageConfiguration` view and `SwitchPageComponent` view. |
There was a problem hiding this comment.
/ The model shared between CheckboxConfiguration view and CheckboxPage view.
| didSet { updateCode() } | ||
| } | ||
|
|
||
| @Published var labelContent: String |
| override init() { | ||
| status = .enabled | ||
| selectorState = .selected | ||
| layout = .selectorOnly |
There was a problem hiding this comment.
Strange to have helperText and other options with switchonly selected
| } | ||
| } | ||
|
|
||
| // MARK: - Switch Demo |
| HStack(alignment: .center) { | ||
| Spacer() | ||
| OUDSCheckbox(state: $model.selectorState, | ||
| isError: model.isError && model.status == CheckboxConfigurationModel.DesignToolboxCheckboxStatus.enabled, |
There was a problem hiding this comment.
reduire CheckboxConfigurationModel.DesignToolboxCheckboxStatus.enabled, .enabled
| /// isError: true, | ||
| /// divider: true) | ||
| /// ``` | ||
| /// |
There was a problem hiding this comment.
Ajouter une exemple du disable
et indiquer ce qui est interdit en complément du warning dans la description
| /// - Parameters: | ||
| /// - state: A binding to a property that determines wether the selector is ticked, unticked or preticked. | ||
| /// - isError: True if the look and feel of the component must reflect an error state, default set to `false` | ||
| /// - isReadOnly: True if component is in read only, i.e. not really disabled but user cannot interact with it yet, default set to `false` |
There was a problem hiding this comment.
Ajouter un warning si disbaled avec error et/ou readonly
|
|
||
| extension Bundle { | ||
|
|
||
| /// The OUDS bundle, useful to find resources | ||
| public static let OUDSComponents = Bundle.module | ||
|
|
||
| /// Loads thefirst preferred localization from main Bundle or if not defined the english one |
| // A leading checkbox with a label | ||
| OUDSCheckbox(state: $state, label: "Hello world") | ||
|
|
||
| // A trailing checkbox with a label, an helper text, an icon, a divider and is about an error |
There was a problem hiding this comment.
ajouter le inverse pour être conforme au commentaire
| @@ -20,7 +20,7 @@ import OUDSTokensSemantic | |||
|
|
|||
| extension OrangeThemeCheckRadioComponentTokensProvider: CheckRadioComponentTokens { | |||
| @objc open var checkRadioSizeMaxHeightAssetsContainer: SizeSemanticToken { DimensionRawTokens.dimension1200 } | |||
| @objc open var checkRadioSizeMaxHeightSelectorOnly: SizeSemanticToken { DimensionRawTokens.dimension600 } | |||
| @objc open var checkRadioSizeMaxHeightSelectorOnly: SizeSemanticToken { DimensionRawTokens.dimension600 } | |||
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
pylapp
added
the
⌛ waiting for validations
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
#264
Description
Add checkbox component
Motivation & Context
Types of change
Previews
Checklist
Contribution
Accessibility
Design
Development
Documentation
Checklist (for Core Team only)