OPHJOD-1198: Update MediaCard #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sauanto
approved these changes
Jan 14, 2025
juhaniko
reviewed
Jan 15, 2025
juhaniko
approved these changes
Jan 15, 2025
ketsappi
force-pushed
the
OPHJOD-1198
branch
2 times, most recently
from
ae2bdc1 to
137fb81
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
variantprop; onlyverticalvariant is left, so there is no longer prop for this.Additional notes
Waiting for design files to be updated, so it might be possible that the horizontal version is not needed as it was used before.
Currently favorite functionality is optional, so if it is undefined --> no heart icon is shown in the upper-right corner. Waiting for answers related to this, is it always wanted to have favorite-button.
Screenshots
Without any favorite info and when it is favorited
Related JIRA ticket
https://jira.eduuni.fi/browse/OPHJOD-1198