This repository has been archived by the owner on Dec 3, 2019. It is now read-only.
🚧 WIP: add tests for the password forgot/reset/update endpoints #464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* controller test for forgot and model test for the generate_password_token! method that forgot uses
robbkidd
force-pushed
the
test-password-resets
branch
from
5020c44 to
541617a
Compare
|
@robbkidd do you know if this is nearly ready? |
|
I mean clearly the tests pass, we should merge and if he wants to do more we can take another PR |
|
🤦♂ I've left this sit for so long I've forgotten what else there was to do. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress. Not ready for merge.
Description of changes
Issue Resolved
Fixes #