-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(shared-data, api): Add evo tips definition and restrictions on loading #17237
Open
Laura-Danielle
wants to merge
6
commits into
chore_release-8.3.0
Choose a base branch
from
PLAT-350-add-evo-tips-tiprack-definitions
base: chore_release-8.3.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
b1f6257
feat(shared_data): Add labware definitions for evotips
Laura-Danielle 40fe2d9
add validation and the definitions to the latest labware def list
Laura-Danielle 1b76cad
addition of evotips adapter as valid parent for evotips and on deck r…
CaseyBatten 1a661ce
update labware definition relative to LPC offsets
CaseyBatten 45cd961
linting fixes
CaseyBatten 48ba251
tip length and overlap
CaseyBatten File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,6 +14,7 @@ const EXPECTED_VALID_QUIRKS = [ | |
'gripperIncompatible', | ||
'tiprackAdapterFor96Channel', | ||
'stackingMaxFive', | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This stackingMaxFive quirk can go away now that its unused in place of the stackLimit and compatibleParentLabware fields. |
||
'stackingOnly', | ||
] | ||
|
||
describe('check quirks for all labware defs', () => { | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
41 changes: 41 additions & 0 deletions
41
shared-data/labware/definitions/2/evotips_flex_96_tiprack_adapter/1.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
{ | ||
"ordering": [], | ||
"brand": { | ||
"brand": "Opentrons", | ||
"brandId": [] | ||
}, | ||
"metadata": { | ||
"displayName": "Evotips adapter", | ||
"displayCategory": "adapter", | ||
"displayVolumeUnits": "\u00b5L", | ||
"tags": [] | ||
}, | ||
"dimensions": { | ||
"xDimension": 156.5, | ||
"yDimension": 105, | ||
"zDimension": 132 | ||
}, | ||
"wells": {}, | ||
"groups": [ | ||
{ | ||
"metadata": {}, | ||
"wells": [] | ||
} | ||
], | ||
"parameters": { | ||
"format": "96Standard", | ||
"quirks": ["tiprackAdapterFor96Channel", "stackingMaxFive"], | ||
"isTiprack": false, | ||
"isMagneticModuleCompatible": false, | ||
"loadName": "evotips_flex_96_tiprack_adapter" | ||
}, | ||
"namespace": "opentrons", | ||
"version": 1, | ||
"schemaVersion": 2, | ||
"allowedRoles": ["adapter"], | ||
"cornerOffsetFromSlot": { | ||
"x": -14.25, | ||
"y": -3.5, | ||
"z": 0 | ||
} | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This quirk is fine, however theres some parallel work going on with the lids behavior that introduced a new labware parameter called
isDeckSlotCompatible
that could be used for the same thing as this quirk. We'll be using it for the tiprack lids and any other lids that cannot be placed on deck, and in theory could use it here too, although it would need to be updated to apply to regular labware loads as well and not just lid stacks. Not a blocker but eventually we'll probably want to consolidate the two.