Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(app-shell): pass team id via env var only #17210

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

sfoster1
Copy link
Member

@sfoster1 sfoster1 commented Jan 8, 2025

This is very odd and I'm not sure when it would have changed but this is the thing the error message says to do.

Testing

  • does the apple build work
  • does the apple build run

This is very odd and I'm not sure when it would have changed but this is
the thing the error message says to do.
@sfoster1 sfoster1 requested a review from a team as a code owner January 8, 2025 14:22
@sfoster1 sfoster1 requested review from mjhuff and removed request for a team January 8, 2025 14:22
Copy link
Contributor

@mjhuff mjhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, this does address the error message. I'm good with this if the test cases pass. Thank you!

@sfoster1
Copy link
Member Author

sfoster1 commented Jan 8, 2025

@sfoster1
Copy link
Member Author

sfoster1 commented Jan 8, 2025

Runs, too!

@sfoster1 sfoster1 merged commit b565fea into chore_release-8.3.0 Jan 8, 2025
57 checks passed
@sfoster1 sfoster1 deleted the fix-team-id-passing branch January 8, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants