-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(components): refactor modal for web (app and pd) #17193
base: edge
Are you sure you want to change the base?
Conversation
refactor modal for web close AUTH-1171
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thank you!
/> | ||
</Btn> | ||
))} | ||
{/* </Flex> */} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this needed?
{/* </Flex> */} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Overview
refactor modal for web
centralizing issue needs more time to fix. (removing
marginLeft
)close AUTH-1171 partially
Test Plan and Hands on Testing
Changelog
Review requests
Risk assessment
low