Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(components): refactor modal for web (app and pd) #17193

Open
wants to merge 10 commits into
base: edge
Choose a base branch
from

Conversation

koji
Copy link
Contributor

@koji koji commented Jan 6, 2025

Overview

refactor modal for web

  • clean up modal header
  • replace from legacy styled text to styled text

centralizing issue needs more time to fix. (removing marginLeft)

close AUTH-1171 partially

Test Plan and Hands on Testing

Changelog

Review requests

Risk assessment

low

@koji koji changed the title refactor(components): refactor modal for web refactor(components): refactor modal for web (app and pd) Jan 7, 2025
@koji koji marked this pull request as ready for review January 7, 2025 20:37
@koji koji requested a review from a team as a code owner January 7, 2025 20:37
Copy link
Contributor

@mjhuff mjhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!

/>
</Btn>
))}
{/* </Flex> */}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this needed?

Suggested change
{/* </Flex> */}

Copy link
Collaborator

@jerader jerader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants