Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api, robot-server, shared-data): add FlexStacker module to the hardware controller and robot server. #17187

Draft
wants to merge 6 commits into
base: edge
Choose a base branch
from

Conversation

vegano1
Copy link
Contributor

@vegano1 vegano1 commented Jan 6, 2025

Overview

Adds the Flex Stacker module to the software stack

Test Plan and Hands on Testing

  • Connect a flex stacker to the flex and make sure the module shows up in the GET /modules endpoint
  • Connect multiple flex stackers to a flex and make sure they both show up

Changelog

  • Add FlexStacker module to the hardware controller
  • Expose FlexStacker module via the robot servers /modules endpoint.

Review requests

  • Anything I'm missing?

Risk assessment

Low, unreleased

TODO

  • add unit tests
  • add rest of the gcode commands

@vegano1 vegano1 self-assigned this Jan 6, 2025
revert debug changes
ZE: bool
ZR: bool
LR: bool
XE: bool = False
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The GCode that we use to get the limit switch statuses always return results for all axes. What are the reasoning behind having setting default values?

return PlatformState.UNKNOWN


class StackerAxisState(Enum):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice - I was actually planning on this exact logic of this in FW. So we can send a GCode querying the axis state, and it will return one of these strings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants