-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(shared-data,-protocol-designer): add foundation for plate reader support in PD #17147
Conversation
… support in PD This PR introduces plate reader to PD, still hidden behind a feature flag. Namely, it adds the ability to add plate reader to the initial deck state and fixes logic for ModuleLabel rendering for all modules. Of note, in this dev work, I discovered a bug in the plate reader's shared-data definition, in which the top-level x and y dimensions were flipped, so those values are swapped here as well.
"xDimension": 155.3, | ||
"yDimension": 95.5, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wow nice catch! there is plate reader support in the app in 8.2. it'd probably be good to post that you found this bug and swapped the values in the protocol execution slack channel so sw folks who worked on plate reader support in app/api are aware
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I did run this by exec/plat and they concur that it was in fact a bug. They're aware of the value swap in this PR
@@ -94,6 +94,7 @@ export const RECOMMENDED_LABWARE_BY_MODULE: { [K in ModuleType]: string[] } = { | |||
], | |||
[ABSORBANCE_READER_TYPE]: [ | |||
'opentrons_flex_lid_absorbance_plate_reader_module', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I know, we don't permit explicit loading of the lid, because we don't treat it like a normal labware. Rather than use move labware commands, the api expects open/close lid commands, which will move the implicitly loaded lid "labware" object.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks amazing, great work! A few questions and comments:
- we aren't supporting MoaM for this launch?
- there's that one plate that isn't showing up:
opentrons_flex_lid_absorbance_plate_reader_module
- is that expected? - great work finding that bug in the def!
- the module tags look a lot better now. feel free to make a follow up ticket and put it in the backlog for us to further fix them in the future. but i think what you have now is sufficient
@jerader thanks for the review:
|
@ncdiehl11 , cool, lets remove it from the array then? because right now it is included in the list of recommended labware |
Overview
This PR introduces plate reader to PD, still hidden behind a feature flag. Namely, it adds the ability to add plate reader to the initial deck state and fixes logic for ModuleLabel rendering for all modules. Of note, in this dev work, I discovered a bug in the plate reader's shared-data definition, in which the top-level x and y dimensions were flipped, so those values are swapped here as well.
Closes AUTH-1077
Test Plan and Hands on Testing
Screen.Recording.2024-12-18.at.8.00.30.PM.mov
Changelog
getModuleModelsBySlot
Review requests
see test plan
Risk assessment
low. behind feature flag and major changes only affect UI for module labels