Skip to content

Commit

Permalink
fix failed tests in protocol engine
Browse files Browse the repository at this point in the history
  • Loading branch information
ahiuchingau committed Jan 7, 2025
1 parent 3887c51 commit ebb6dbc
Show file tree
Hide file tree
Showing 6 changed files with 1,146 additions and 307 deletions.
2 changes: 1 addition & 1 deletion api/src/opentrons/protocol_api/core/engine/module_core.py
Original file line number Diff line number Diff line change
Expand Up @@ -697,7 +697,7 @@ def is_lid_on(self) -> bool:

class FlexStackerCore(ModuleCore, AbstractFlexStackerCore):
"""Flex Stacker core logic implementation for Python protocols."""

_sync_module_hardware: SynchronousAdapter[hw_modules.FlexStacker]

def retrieve(self) -> None:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ def __init__(
async def execute(self, params: StoreParams) -> SuccessData[StoreResult]:
"""Execute the labware storage command."""
return SuccessData(public=StoreResult())


class Store(BaseCommand[StoreParams, StoreResult, ErrorOccurrence]):
"""A command to store a labware in a Flex Stacker."""
Expand Down
6 changes: 2 additions & 4 deletions api/src/opentrons/protocol_engine/state/modules.py
Original file line number Diff line number Diff line change
Expand Up @@ -764,10 +764,8 @@ def get_absorbance_reader_substate(
expected_type=AbsorbanceReaderSubState,
expected_name="Absorbance Reader",
)

def get_flex_stacker_substate(
self, module_id: str
) -> FlexStackerSubState:

def get_flex_stacker_substate(self, module_id: str) -> FlexStackerSubState:
"""Return a `FlexStackerSubState` for the given Flex Stacker.
Raises:
Expand Down
2 changes: 1 addition & 1 deletion api/src/opentrons/protocol_engine/types.py
Original file line number Diff line number Diff line change
Expand Up @@ -536,7 +536,7 @@ def is_absorbance_reader(
) -> TypeGuard[AbsorbanceReaderModel]:
"""Whether a given model is an Absorbance Plate Reader."""
return model == cls.ABSORBANCE_READER_V1

@classmethod
def is_flex_stacker(cls, model: ModuleModel) -> TypeGuard[FlexStackerModel]:
"""Whether a given model is a Flex Stacker."""
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,11 @@ def test_get_provided_addressable_area_names(
cutout_fixture_id="stagingAreaRightSlot",
provided_addressable_areas=frozenset({"D3", "D4"}),
),
PotentialCutoutFixture(
cutout_id="cutoutD3",
cutout_fixture_id="flexStackerV1",
provided_addressable_areas=frozenset({"D3", "flexStackerV1D4"}),
),
},
lazy_fixture("ot3_standard_deck_def"),
),
Expand Down
Loading

0 comments on commit ebb6dbc

Please sign in to comment.