Skip to content

Commit

Permalink
fix(app): fix gray run status when pressing "return to dash" on `RunS…
Browse files Browse the repository at this point in the history
…ummary` (#16223)

Closes RQA-3159

Fixes the run status changing to gray when clicking "return to dashboard" on the ODD RunSummary page.

The run status graying on button click has always been in the code, but because we used to navigate immediately after clicking "return to dashboard", this wasn't a user-visible problem.
  • Loading branch information
mjhuff authored Sep 10, 2024
1 parent b0b8221 commit 9916a7c
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions app/src/pages/RunSummary/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ export function RunSummary(): JSX.Element {
const trackEvent = useTrackEvent()
const { trackEventWithRobotSerial } = useTrackEventWithRobotSerial()

const { closeCurrentRun, isClosingCurrentRun } = useCloseCurrentRun()
const { closeCurrentRun } = useCloseCurrentRun()
// Close the current run only if it's active and then execute the onSuccess callback. Prefer this wrapper over
// closeCurrentRun directly, since the callback is swallowed if currentRun is null.
const closeCurrentRunIfValid = (onSuccess?: () => void): void => {
Expand Down Expand Up @@ -386,7 +386,6 @@ export function RunSummary(): JSX.Element {
flexDirection={DIRECTION_COLUMN}
position={POSITION_RELATIVE}
overflow={OVERFLOW_HIDDEN}
disabled={isClosingCurrentRun}
onClick={handleClickSplash}
>
{showSplash ? (
Expand Down

0 comments on commit 9916a7c

Please sign in to comment.