Add ERC1155 #896
Add ERC1155 #896
Conversation
Update error testing and remove tests failing from erc1155
…iro-contracts into feat/erc1155-#572
|
hey @ericnordelo do not hesitate to ask me for the review if needed. Let me know when I can start it 👍 |
There was a problem hiding this comment.
Good job @cloudvenger and @ericnordelo! I think it's ok to leave the docs for a different PR to avoid a gigantic one, but do need to add more tests, especially for the new ERC1155 preset.
|
I did finish testing the ERC1155 component. Tomorrow I will check the dual case and the preset test modules. |
There was a problem hiding this comment.
Great work, @cloudvenger @ericnordelo! I left some feedback :)
@ericnordelo whoops, just saw this^. Don't mind my dual case comments 😅 |
| } | ||
|
|
||
| #[test] | ||
| fn test_update_wac_from_zero_to_non_zero_camel_receiver() { |
There was a problem hiding this comment.
wac sounds like guac to me
Co-authored-by: Martín Triay <[email protected]>
…racts into feat/erc1155-#572
| use openzeppelin::tests::token::test_erc1155::{ | ||
| assert_only_event_transfer_single, assert_only_event_transfer_batch, | ||
| assert_only_event_approval_for_all | ||
| }; | ||
| use openzeppelin::tests::token::test_erc1155::{ | ||
| setup_account, setup_receiver, setup_camel_receiver, setup_account_with_salt, setup_src5 | ||
| }; |
There was a problem hiding this comment.
I wonder if it'd make sense to create more granular utils for tests. setup_account, for example, can be useful in a a few test modules. Just a thought for the future
There was a problem hiding this comment.
I think that's probably worth it, yes
Fixes #572
PR Checklist