Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaned Up Godot Assets Structure #197

Merged
merged 3 commits into from
Jan 21, 2024
Merged

Cleaned Up Godot Assets Structure #197

merged 3 commits into from
Jan 21, 2024

Conversation

BrickPi
Copy link
Contributor

@BrickPi BrickPi commented Jan 19, 2024

  • Added Application Icons for Windows, Mac, and Linux
  • Localised "Asset Path Not Found" message box and reworded message to be less technical.
  • Moved localisation to assets/localisation
  • Moved audio to assets/audio
  • Removed legacy assets from repo pending custom mode, still retained in Google Drive.
  • Moved quotes.txt and credits.csv to assets/localisation
  • Removed unused assets in common
  • Moved theme to assets/graphics/theme
  • Moved used assets under art to assets/graphics

All suggestions are welcome.

Open to extending reorganisation to the src folder to reflect new needs after pivoting to compatibility.

Eventually will need to refactor credits to better reflect organisation of project and accretion of new contributors.

All modified features tested and working. :-)

@BrickPi BrickPi requested review from Hop311 and Spartan322 January 19, 2024 22:07
@Spartan322 Spartan322 added the enhancement New feature or request label Jan 19, 2024
Copy link
Member

@Spartan322 Spartan322 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linux crashes with WARNING: Icon too large, attempting to resize icon.

@Spartan322
Copy link
Member

Spartan322 commented Jan 20, 2024

Something is seriously wrong with running the files built on Ubuntu with Arch Linux.

Copy link
Contributor

@Hop311 Hop311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I exported locally and tried running the exe, the whole screen would get a white tint, like when a program stops responding, and then just stopped, so something's broken (this was yesterday morning, I'll try again with the recent changes later today).

game/src/Game/GameStart.gd Outdated Show resolved Hide resolved
@BrickPi
Copy link
Contributor Author

BrickPi commented Jan 21, 2024

Everything should finally be fixed and working 😭

@BrickPi BrickPi merged commit 0840fd6 into master Jan 21, 2024
16 checks passed
@BrickPi BrickPi deleted the reorganising branch January 21, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants