Development #247
Merged
Development #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still need to sweep the code for possible uses of these.
When fetching stuff for phylesystemapi's RAM cache, so far we have simply repeated all request headers in the proxied request. But our Pyramid implementation will not support Keep-Alive or some other headers because we're running it under a WSGI server (waitress).
This should address the problem of getting bogus cached values when the URL is an exact match (useless for POST requests).
This should eliminate goofy cache hits that return, e.g., a synth-subtree from a prior/different request.
only render to JSON if outformat is json
log exceptions generated when fetching a study from the docstore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is actually deployed to production so may as well call it main.