Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit query tag in ES query #1513

Merged
merged 4 commits into from
Jan 30, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -315,19 +315,31 @@ public Deferred<MetaDataStorageResult> runQuery(
filter = queryPipelineContext.query().getFilter(
timeSeriesDataSourceConfig.getFilterId());
}

final ChainFilter.Builder builder = ChainFilter.newBuilder()
.setOp(FilterOp.AND)
.addFilter(MetricLiteralFilter.newBuilder()
.setMetric(metric)
.build());

QueryFilter buildFilter;

final ChainFilter.Builder builder = ChainFilter
.newBuilder()
.setOp(FilterOp.AND)
.addFilter(MetricLiteralFilter.newBuilder().setMetric(metric).build());
if (filter != null) {
builder.addFilter(filter);
}

if (filter instanceof ExplicitTagsFilter) {
final ExplicitTagsFilter.Builder explicitTagBuilder =
ExplicitTagsFilter
.newBuilder()
.setFilter(builder.build());
buildFilter = explicitTagBuilder.build();
} else {
buildFilter = builder.build();
}

final MetaQuery query = DefaultMetaQuery.newBuilder()
.setType(QueryType.TIMESERIES)
.setNamespace(namespace)
.setFilter(builder.build())
.setFilter(buildFilter)
.build();

SearchSourceBuilder search = NamespacedAggregatedDocumentQueryBuilder
Expand Down Expand Up @@ -663,4 +675,4 @@ private TimeSeriesId buildTimeseries(final String metric, final
return timeseries;
}

}
}
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,36 @@ public void testTagValueRegexQuery() {
+ "{\"term\":{\"tags.key.lowercase\":\"host\"}}]}},\"path\":\"tags\"}}"));

}

@Test
public void testExplicitTagQuery() {

QueryFilter chainFil = ChainFilter.newBuilder().setOp(ChainFilter.FilterOp.AND)
.addFilter(TagValueRegexFilter.newBuilder().setFilter("cpu").setTagKey("host").build())
.build();
MetaQuery query = DefaultMetaQuery.newBuilder()
.setFrom(0)
.setTo(5)
.setNamespace("Yahoo")
.setFilter( ExplicitTagsFilter.newBuilder().setFilter(chainFil).build())
.setType(QueryType.TIMESERIES)
.build();

SearchSourceBuilder source = NamespacedAggregatedDocumentQueryBuilder
.newBuilder(query)
.build();

String s = source.toString().replaceAll("\n","")
.replaceAll(" ", "");
System.out.println(s);
assertTrue(s.contains("\"from\":0"));
assertTrue(s.contains("\"size\":5"));
assertTrue(s.contains("\"query\":{\"bool\":{\"must\":[{\"term\":{\"tags_value\":1}},{\"bool\":"
+ "{\"must\":{\"nested\":{\"filter\":{\"bool\":{\"must\":[{\"regexp\":"
+ "{\"tags.value\":\".*cpu.*\"}},{\"term\":{\"tags.key.lowercase\":\"host\"}}]}},"
+ "\"path\":\"tags\"}}}}]}}"));

}
//
// @Test
// public void testMetricRegexQuery() {
Expand Down