Update rust

[AnthonyRonning]

Summary by CodeRabbit

• Chores
  • Updated the Rust toolchain configuration to a stable release (1.84.1) to enhance stability and reliability.
• New Features
  • Streamlined session management by removing the shared_secret field from the session state structure, simplifying the session handling process.

[coderabbitai]

"""

Walkthrough

The changes update the Rust toolchain configuration by modifying the rust-toolchain.toml file. The toolchain channel has been changed from the nightly version (nightly-2024-07-25) to a stable release version (1.84.1), reflecting a shift in the Rust environment setup. Additionally, the SessionState struct in src/web/attestation_routes.rs has been simplified by removing the shared_secret field and associated logic, streamlining session management.

Changes

File	Changes Summary
rust-toolchain.toml	Updated the channel from nightly-2024-07-25 to stable release 1.84.1
src/web/attestation_routes.rs	Removed shared_secret field from SessionState, updated constructor, and removed encrypt method

Poem

I'm a rabbit with a skipping heart,
Hopping on code paths to play my part.
Nightly builds leave a jittery trace,
Now stable rules bring a calm embrace.
With version 1.84.1, my leaps are light and free!
🐇 Coding in wonder, just you wait and see!
"""

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c19e5d6 and d08ea99.

⛔ Files ignored due to path filters (3)

• flake.lock is excluded by !**/*.lock
• pcrDev.json is excluded by !pcrDev.json
• pcrProd.json is excluded by !pcrProd.json

📒 Files selected for processing (2)

• rust-toolchain.toml (1 hunks)
• src/web/attestation_routes.rs (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• rust-toolchain.toml

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: Development Reproducible Build

🔇 Additional comments (2)

src/web/attestation_routes.rs (2)

24-26: LGTM! The simplified SessionState improves encapsulation.

The removal of the shared_secret field and associated encryption logic makes the SessionState more focused on session management. The shared secret is correctly used only during key exchange and not stored afterward, which aligns with cryptographic best practices.

Also applies to: 28-31

---

450-453: LGTM! The session state management is secure and minimal.

The simplified session state creation maintains security while storing only the essential session key. The shared secret is correctly used only for the initial key exchange and not persisted, following the principle of minimal data retention.

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🔭 Outside diff range comments (1)

src/web/attestation_routes.rs (1)

443-447: ⚠️ Potential issue

Security: Remove logging of sensitive cryptographic material.

The session key and nonce should not be logged, even at trace level, as they are sensitive cryptographic materials. If logging is needed for debugging, consider logging non-sensitive metadata instead.

Apply this diff to remove the sensitive data from logs:

-    trace!(
-        "Generated session key {:?} for nonce {:?}",
-        session_key,
-        nonce
-    );
+    trace!("Generated new session key");

🧹 Nitpick comments (1)

src/web/attestation_routes.rs (1)

24-26: LGTM! Good simplification of the SessionState struct.

The removal of the shared_secret field and simplification of the constructor makes the session management more focused and maintainable. The shared secret is only needed during key exchange and doesn't need to be stored in the session state.

Consider adding documentation comments to explain the purpose of the struct and its fields:

+/// Represents the state of an active session
 pub struct SessionState {
+    /// The session key used for encrypting/decrypting session data
     session_key: [u8; 32],
 }

Also applies to: 28-31

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0fe9bbb and c19e5d6.

📒 Files selected for processing (1)

• src/web/attestation_routes.rs (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (3)

• GitHub Check: Clippy
• GitHub Check: Test Suite
• GitHub Check: Development Reproducible Build

🔇 Additional comments (1)

src/web/attestation_routes.rs (1)

450-453: LGTM! Clean session state initialization.

The simplified session state initialization aligns well with the struct changes, maintaining only the necessary session key.