Modify the Change Request base module to make it OpenSPP independent #736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to be OpenSPP independent
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this change needed?
The current spp_change_request module is dependent on OpenG2P and OpenSPP base modules. There is a need for the change request base module to be used in other implementations where OpenG2P and/or OpenSPP is not needed.
How was the change implemented?
A new spp_change_request_base module was developed and will be the parent module for all change request type modules. Implementation-specific requirements for change request can now be handled in the change request type modules.
New unit tests
Unit tests executed by the author
How to test manually
Related links