Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test errors #718

Merged
merged 13 commits into from
Feb 6, 2025
Merged

Fix test errors #718

merged 13 commits into from
Feb 6, 2025

Conversation

gonzalesedwin1123
Copy link
Member

Why is this change needed?

Errors are reported in the tests.

How was the change implemented?

  • Check the errors reported in the test with Odoo 17/Ubuntu 22.04
  • Fix the code to resolve the errors

New unit tests

Unit tests executed by the author

How to test manually

Related links

@gonzalesedwin1123 gonzalesedwin1123 linked an issue Jan 9, 2025 that may be closed by this pull request
Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.80%. Comparing base (d50ba4c) to head (2615b43).
Report is 86 commits behind head on 17.0.

Additional details and impacted files
@@            Coverage Diff             @@
##             17.0     #718      +/-   ##
==========================================
- Coverage   76.23%   75.80%   -0.43%     
==========================================
  Files         687      706      +19     
  Lines       17777    17906     +129     
  Branches     2205     2225      +20     
==========================================
+ Hits        13552    13574      +22     
- Misses       3774     3869      +95     
- Partials      451      463      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gonzalesedwin1123 gonzalesedwin1123 marked this pull request as ready for review January 27, 2025 02:07
@gonzalesedwin1123 gonzalesedwin1123 requested review from kneckinator and removed request for jeremi January 27, 2025 02:07
@kneckinator
Copy link
Contributor

Rebasing on latest 17.0 before approving/merging.

@kneckinator kneckinator force-pushed the 717-fix-errors-in-the-tests branch from e17f72a to 2615b43 Compare February 6, 2025 03:47
Copy link

sonarqubecloud bot commented Feb 6, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
6.2% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Copy link
Contributor

@kneckinator kneckinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge. Tests are also passing after rebase.

@kneckinator kneckinator merged commit 9d21f2d into 17.0 Feb 6, 2025
6 of 7 checks passed
@kneckinator kneckinator deleted the 717-fix-errors-in-the-tests branch February 6, 2025 05:29
@github-actions github-actions bot locked and limited conversation to collaborators Feb 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix errors in the tests
3 participants