Build and packaging-related fixes #28
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This project seems to include portions of code under MIT, so formally any derived work has to follow the terms of both Apache 2 and MIT licenses.
|
@feliwir, hey! Friendly ping :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noted that the generators project has to be built separately if you open the project in the IDE, so I've decided to add the contributor guide (named and placed according to the established practice).
Note that it doesn't affect build from shell, only build from the IDE. Checked in both Visual Studio and Rider, and both are broken until you build the generators.
Also note how nice does the
**Note**block looks after GitHub renders it. It is a less known feature of GitHub Markdown renderer I've decided to use here :)This isn't a big deal, but the project includes portions of code licensed under the MIT license, alongside the main Apache-2. That means that derived works should follow both terms of MIT and Apache-2 simultaneously.
NuGet supports special syntax of SPDX license expressions to express situations like this, so I've upgraded the package metadata accordingly.
You can check that my expression is correct by following this link (it is included into the
.nuspecgenerated bydotnet packas well): https://licenses.nuget.org/Apache-2.0%20AND%20MITI've also added some minor pieces of NuGet metadata for the package to look nicer on nuget.org. We deserve better than the infamous "Package Description", do we? :)