front: fix some issues in stdcm consist errors tooltips #10287
+3
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
SharglutDev
commented
Jan 8, 2025
SharglutDev
commented
- Tooltip position in consist form should be always left
- The launch button shouldn't be disabled if a tooltip is displayed
- Tooltip position in consist form should be always left - The launch button shouldn't be disabled if a tooltip is displayed Signed-off-by: SharglutDev <[email protected]>
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #10287 +/- ##
==========================================
- Coverage 81.53% 81.51% -0.02%
==========================================
Files 1059 1059
Lines 104459 104456 -3
Branches 722 722
==========================================
- Hits 85166 85145 -21
- Misses 19252 19270 +18
Partials 41 41
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
emersion
reviewed
Jan 8, 2025
emersion
approved these changes
Jan 8, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.