-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: fix scroll in stdcm result table #10274
base: dev
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #10274 +/- ##
===========================================
+ Coverage 81.45% 87.50% +6.05%
===========================================
Files 1058 31 -1027
Lines 104235 1537 -102698
Branches 722 0 -722
===========================================
- Hits 84907 1345 -83562
+ Misses 19287 192 -19095
+ Partials 41 0 -41
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: romainvalls <[email protected]>
f26cd69
to
e0b28c5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems ok but just a suggestion:
to fit on screens, you could set a height
on .stdcm__body
:
height: calc(100vh - 120px);
(100vh - stdcm navbar)
then remove your max-height
and set a height on .simulation-results
:
height: calc(100vh - 180px);
(100vh - y-paddings - simulation-list height)
this way the should always fit on every screen heights
can you try it?
@kmer2016 do you agree?
I agree with the idea of making the height dynamic to improve responsiveness. However, after testing this approach, it slightly breaks the current layout. .table-container {
height: calc(100vh - 120px);
overflow-y: auto;
} |
close #9625
Decided to put a max height of 80vh to prevent the results from increasing page size too much.
Can be changed for lesser / higher value if you think it's better to.