Filter TowedRollingStocks to include only allowed values #10227

achrafmohye · 2025-01-03T09:31:18Z

Closes #10120

codecov-commenter · 2025-01-03T09:33:25Z

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.51%. Comparing base (9109fb7) to head (81f88fa).
Report is 4 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##              dev   #10227      +/-   ##
==========================================
- Coverage   81.53%   81.51%   -0.02%     
==========================================
  Files        1059     1059              
  Lines      104459   104493      +34     
  Branches      722      722              
==========================================
+ Hits        85166    85182      +16     
- Misses      19252    19270      +18     
  Partials       41       41

Flag	Coverage Δ
editoast	`73.68% <ø> (-0.06%)`	⬇️
front	`89.25% <100.00%> (+<0.01%)`	⬆️
gateway	`2.18% <ø> (ø)`
osrdyne	`3.28% <ø> (ø)`
railjson_generator	`87.50% <ø> (ø)`
tests	`87.05% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

front/src/applications/stdcm/consts.ts

front/src/modules/towedRollingStock/hooks/useFilterTowedRollingStock.ts

Uriel-Sautron

Good work, tested.
Agree with @SharglutDev comments

front/src/applications/stdcm/types.ts

front/src/applications/stdcm/components/StdcmForm/StdcmConsist.tsx

SharglutDev

Lgtm and tested

…lues Signed-off-by: Achraf Mohyeddine <[email protected]>

Maymanaf

LGTM for e2e-tests

achrafmohye requested a review from a team as a code owner January 3, 2025 09:31

github-actions bot added the area:front Work on Standard OSRD Interface modules label Jan 3, 2025

achrafmohye changed the title ~~filter TowedRollingStocks to include only allowed values~~ Filter TowedRollingStocks to include only allowed values Jan 3, 2025

SharglutDev requested review from Uriel-Sautron and SharglutDev January 3, 2025 14:41

SharglutDev reviewed Jan 3, 2025

View reviewed changes

front/src/applications/stdcm/consts.ts Outdated Show resolved Hide resolved

front/src/modules/towedRollingStock/hooks/useFilterTowedRollingStock.ts Outdated Show resolved Hide resolved

Uriel-Sautron reviewed Jan 6, 2025

View reviewed changes

SharglutDev reviewed Jan 6, 2025

View reviewed changes

front/src/applications/stdcm/types.ts Outdated Show resolved Hide resolved

front/src/applications/stdcm/components/StdcmForm/StdcmConsist.tsx Outdated Show resolved Hide resolved

achrafmohye force-pushed the ame/filter-allowed-towed-rolling-stocks branch from ae9c16a to 5240600 Compare January 8, 2025 08:51

SharglutDev approved these changes Jan 8, 2025

View reviewed changes

achrafmohye force-pushed the ame/filter-allowed-towed-rolling-stocks branch 2 times, most recently from 20f206f to d030951 Compare January 8, 2025 15:12

achrafmohye requested a review from a team as a code owner January 8, 2025 15:12

front: filter fetched towed rolling stocks to include only allowed va…

81f88fa

…lues Signed-off-by: Achraf Mohyeddine <[email protected]>

achrafmohye force-pushed the ame/filter-allowed-towed-rolling-stocks branch from d030951 to 81f88fa Compare January 8, 2025 15:19

achrafmohye enabled auto-merge January 8, 2025 15:22

Maymanaf approved these changes Jan 8, 2025

View reviewed changes