Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fixture evolight/evolite #4526

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Add fixture evolight/evolite #4526

wants to merge 1 commit into from

Conversation

FloEdelmann
Copy link
Member

  • Add fixture evolight/evolite

Thank you LudoLight!

@FloEdelmann FloEdelmann added new-fixture Request or implementation to add a new fixture definition. via-editor Opened via the editor on the open-fixture-library.org website. labels Jan 6, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 6, 2025

Export files validity

(Output of test script tests/github/exports-valid.js.)

Test the exported files of selected fixtures against the plugins' export tests.
You can run a plugin's export tests by executing:
$ node cli/run-export-test.js -p <plugin name> <fixtures>

✔️ evolight / evolite: d-light / attributes-correctness
  • ✔️ evolight/evolite-3 CANAUX.xml
✔️ evolight / evolite: dmxcontrol3 / channel-numbers
  • ✔️ evolight-evolite-3-CANAUX.xml
✔️ evolight / evolite: dragonframe / json-schema-conformity
  • ✔️ evolight/evolite.json
  • ✔️ manufacturers.json
✔️ evolight / evolite: millumin / json-schema-conformity
  • ✔️ evolight/evolite.json
❌ evolight / evolite: qlcplus_4.12.2 / fixture-tool-validation
  • ❌ fixtures/Evolight-EVOLITE.qxfNamespace(map=False, convert=None, validate=['.']) Starting validation ./manufacturer/fixture.qxf: Invalid physical dimensions detected 1 definitions processed. 1 errors detected
❌ evolight / evolite: qlcplus_4.12.2 / xsd-schema-conformity
  • ❌ fixtures/Evolight-EVOLITE.qxfElement '{http://www.qlcplus.org/FixtureDefinition}Dimensions', attribute 'Weight': [facet 'minExclusive'] The value '0' must be greater than '0'.
    Element '{http://www.qlcplus.org/FixtureDefinition}Dimensions', attribute 'Width': '0' is not a valid value of the atomic type 'xs:positiveInteger'.
    Element '{http://www.qlcplus.org/FixtureDefinition}Dimensions', attribute 'Height': '0' is not a valid value of the atomic type 'xs:positiveInteger'.
    Element '{http://www.qlcplus.org/FixtureDefinition}Dimensions', attribute 'Depth': '0' is not a valid value of the atomic type 'xs:positiveInteger'.

kengruven
kengruven reviewed Jan 8, 2025
View reviewed changes
fixtures/evolight/evolite.json
Comment on lines +23 to +25
"rdm": {
"modelId": 0
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"rdm": {
"modelId": 0
},

fixtures/evolight/evolite.json
Comment on lines +12 to +21
"links": {
"manual": [
"https://www.manualslib.com/products/Evolite-Frz-100ww-13707541.html?utm_source=chatgpt.com"
],
"productPage": [
"https://www.manualslib.com/products/Evolite-Frz-100ww-13707541.html?utm_source=chatgpt.com"
],
"video": [
"https://www.manualslib.com/products/Evolite-Frz-100ww-13707541.html?utm_source=chatgpt.com"
]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"links": {
"manual": [
"https://www.manualslib.com/products/Evolite-Frz-100ww-13707541.html?utm_source=chatgpt.com"
],
"productPage": [
"https://www.manualslib.com/products/Evolite-Frz-100ww-13707541.html?utm_source=chatgpt.com"
],
"video": [
"https://www.manualslib.com/products/Evolite-Frz-100ww-13707541.html?utm_source=chatgpt.com"
]
"links": {
"manual": [
"https://www.manualslib.com/products/Evolite-Frz-100ww-13707541.html"
]

fixtures/evolight/evolite.json
Comment on lines +3 to +4
"name": "EVOLITE",
"shortName": "FR100Z",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"name": "EVOLITE",
"shortName": "FR100Z",
"name": "FRZ-100WW",

Might be worthwhile to change the filename to "frz-100ww.json" or similar, too. Is the filename considered user-facing, or just an implementation detail?

fixtures/evolight/evolite.json
"$schema": "https://raw.githubusercontent.com/OpenLightingProject/open-fixture-library/master/schemas/fixture.json",
"name": "EVOLITE",
"shortName": "FR100Z",
"categories": ["Dimmer"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"categories": ["Dimmer"],
"categories": ["Other"],

fixtures/evolight/evolite.json
},
"physical": {
"lens": {
"degreesMinMax": [10, 50]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"degreesMinMax": [10, 50]
"degreesMinMax": [10, 60]

fixtures/evolight/evolite.json
Comment on lines +65 to +66
"speedEnd": "fast",
"comment": "STROB SLOW"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"speedEnd": "fast",
"comment": "STROB SLOW"
"speedEnd": "fast"

fixtures/evolight/evolite.json
Comment on lines +71 to +72
"shutterEffect": "Closed",
"comment": "NO STROB"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"shutterEffect": "Closed",
"comment": "NO STROB"
"shutterEffect": "Open"

fixtures/evolight/evolite.json
Comment on lines +76 to +78
"type": "ShutterStrobe",
"shutterEffect": "Open",
"comment": "ALEATOIRE - RANDOM"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"type": "ShutterStrobe",
"shutterEffect": "Open",
"comment": "ALEATOIRE - RANDOM"
"type": "Effect",
"effectPreset": "Strobe",
"randomTiming": true

fixtures/evolight/evolite.json
},
"modes": [
{
"name": "3 CANAUX",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"name": "3 CANAUX",
"name": "3-channel",

fixtures/evolight/evolite.json
}
},
"modes": [
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{
{
"name": "1-channel",
"channels": [
"Dimmer"
]
},
{
"name": "2-channel",
"channels": [
"Dimmer",
"Dimmer fine"
]
},
{

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kengruven kengruven kengruven left review comments

Assignees
No one assigned
Labels
new-fixture Request or implementation to add a new fixture definition. via-editor Opened via the editor on the open-fixture-library.org website.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FloEdelmann @kengruven