Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Get Started" and "Guides" links in footer #3905

Merged

Conversation

JavierABarreto
Copy link

@JavierABarreto JavierABarreto commented Nov 19, 2024

What was changed and why? issue #3808

  • Added "Get Started" & "Guides" links in footer.
  • Modified the order of the links to maintain consistency with header.

Tested using browser:

  • Firefox (Desktop)
  • Safari (Desktop)
  • Chrome (Desktop)

Did you test accessibility:

  • IBM Equal Access Accessibilty Checker
  • Jaws (only relevant for new UX flows)

@JavierABarreto JavierABarreto changed the title rebasing prod Add "Get Started" and "Guides" links in footer. Nov 19, 2024
@JavierABarreto JavierABarreto changed the title Add "Get Started" and "Guides" links in footer. Add "Get Started" and "Guides" links in footer Nov 19, 2024
@SteveSamJacob19 SteveSamJacob19 self-requested a review November 21, 2024 15:28
@JavierABarreto JavierABarreto force-pushed the adding-links-in-footer branch 2 times, most recently from e9c7107 to 0fe8634 Compare November 22, 2024 15:53
@SteveSamJacob19
Copy link
Contributor

@JavierABarreto Just to clarify, did u make any additional changes here that you havent in draft?

@JavierABarreto
Copy link
Author

@SteveSamJacob19 No, I did the same changes that I did on draft.

@SteveSamJacob19 SteveSamJacob19 merged commit 853ebcc into OpenLiberty:staging Dec 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants