Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use LMP for copyDeps in package #52

Open
wants to merge 1 commit into
base: staging
Choose a base branch
from

Conversation

scottkurz
Copy link
Member

@scottkurz scottkurz commented Feb 20, 2024

Fixes #41.

Might be better just to bind the 'create' goal to prepare-package. At least we don't have to duplicate the copyDeps config in the dependency-plugin.

This overlaps the discussion in OpenLiberty/ci.maven#739

Obviously the doc would need to be updated, just wanted to raise the suggestion as a first step.

@gkwan-ibm
Copy link
Member

hi @scottkurz

Your PR may work, although I didn't try it yet. For CI/CD automation, I compared the current way and your way:

  1. cd finish
  2. mvn clean package
  3. mvn verify

For step 2, war file was built and

  • the current way only downloaded the postgresql library
  • beside the postgresql library, your way downloaded and installed kernel Liberty that is an overhead and is not necessary.

@scottkurz
Copy link
Member Author

For step 2, war file was built and

* the current way only downloaded the postgresql library

* beside the postgresql library, your way downloaded and installed kernel Liberty that is an overhead and is not necessary.

Yes, that's true there is an additional cost to download the kernel runtime.

It would be nice if we could get around to improving LMP here. Note that besides the OpenLiberty/ci.maven#739 issue I mentioned we could also consider something like:
OpenLiberty/ci.maven#1094 to do a create without an install.

But IMO, it's worth to have the extra overhead for the simpler developer experience and not having to have the extra plugin config in the pom.xml. I usually develop from a workstation, where I only have to download a new kernel once a month. If this is primarily going to run in some kind of container/cloud env, however, it might happen every time. Still it's only about ~10M download, so not much.

@gkwan-ibm gkwan-ibm changed the base branch from prod to staging April 4, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

is there an alternative to copy the postgres library?
2 participants