Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a YamlGenerator to ModsManager #959

Merged
merged 22 commits into from
Mar 11, 2024

Conversation

kenjiuno
Copy link
Collaborator

@kenjiuno kenjiuno commented Dec 29, 2023

2do

  • Try to merge also binarc entries when merging mod.yml before launching diff tool
  • Complement some descriptions for new ui.

Screenshots

Main

2024-01-04_17h44_36

2024-03-11_22h45_04

binarc

2024-03-11_23h04_37

2024-01-04_17h45_10

2024-01-04_17h48_19

2024-01-04_17h48_22

path

2024-03-11_23h06_39

2024-03-11_23h19_33

@kenjiuno kenjiuno changed the title WIP Adding a YamlGenerator to ModsManager Adding a YamlGenerator to ModsManager Jan 22, 2024
@kenjiuno kenjiuno marked this pull request as ready for review January 22, 2024 12:51
@shananas
Copy link
Collaborator

went ahead and approved it looks good. Feel free to merge once the conflict is resolved

@TopazTK
Copy link
Collaborator

TopazTK commented Jan 29, 2024

I am not for merging this until the text and the UI is "beautified" a little. Right now, it looks like a concept or an incomplete feature (because it was at the time). Can I please ask anyone to fix the text/labels/titles up just a bit?

Really appreciate the work, but these sorts of small details will cause many to have doubts about the legitimacy of the feature and steer away from using it.

@Oathseeker
Copy link
Collaborator

I think the UI is fine, I am in favor of approval, this is functional.

@kenjiuno
Copy link
Collaborator Author

I have attached the short helpful text to silent UI parts.
Although I know that this extra will disturb the well practiced creators, this will help for beginners or having temporary forgetfulness case.

@kenjiuno kenjiuno merged commit b304c82 into OpenKH:master Mar 11, 2024
3 checks passed
@kenjiuno kenjiuno deleted the fix-add-OpenKh.Tools.YamlGenerator branch March 11, 2024 14:33
kenjiuno added a commit to kenjiuno/OpenKh that referenced this pull request Apr 17, 2024
- I forgot to commit to git these changes which should be applied to OpenKH#959.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants