-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mod Manager Lua engine integration and Presets #858
Conversation
Load Preset menu doesnt update when saving a new preset until you restart Mod Manager. Any text that isnt A-Z or 0-9 will be replcaed by + so the file can save.
…anager then remove preset from the folder) other small changes.
Lua Engine download from https://github.com/TopazTK/LuaEngine
…mbols of other languages in presets
…a zip. Also merged Preset Regex improvement.
…rease. Basically done for when Lua Engine is ready for full release.
# Conflicts: # OpenKh.Tools.ModsManager/ViewModels/MainViewModel.cs
# Conflicts: # OpenKh.Tools.ModsManager/ViewModels/MainViewModel.cs
I haven't messed around with presets but I don't think the basic structure for them is ready.
Sample code:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a way to remove presets.
Lua engine integration
…t file when you do delete and confirm.
LGTM! |
Back to draft until Lua Engine and common Lua scripts work nicely together unless Topaz is happy with current Lua Engine |
I am happy with the state of the current LuaEngine, but give time for 1-2 more releases. |
so all the needed .dlls are in one folder
# Conflicts: # OpenKh.Tools.ModsManager/Services/ConfigurationService.cs # OpenKh.Tools.ModsManager/Services/ModsService.cs # OpenKh.Tools.ModsManager/ViewModels/MainViewModel.cs
# Conflicts: # OpenKh.Tools.ModsManager/ViewModels/MainViewModel.cs
Adds Presets and Lua Engine integration.
When saving a new preset you will need to restart mod manager for the preset to show under Load Presets. If you save a preset with the same name as one that already exists it will override it and a restart will not be necessary. If you try to include characters in the name that windows does not let be in a filename it will automatically be replaced by +.
Adds an install Lua Engine option into the setup wizard if you chose PC version. Can either download and configure Lua Engine to automatically load scripts installed in Mod Manager. Or if you have it installed already can locate where Lua Engine is installed and use it from there and configure it to load scripts from Mod Manager.
![image](https://private-user-images.githubusercontent.com/47014056/264745949-7ffd80f4-26ff-429f-b94d-11235213cd77.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg5MTAzMzIsIm5iZiI6MTczODkxMDAzMiwicGF0aCI6Ii80NzAxNDA1Ni8yNjQ3NDU5NDktN2ZmZDgwZjQtMjZmZi00MjlmLWI5NGQtMTEyMzUyMTNjZDc3LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA3VDA2MzM1MlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTUxMDBhYTM0YzgxZWNhYzk3YTk1ZTMxOGY4ZmMzNzIxNWQwYzAxZWYxYTZmNDUzOTQ0ZjAxYzMyZWM3NzQxN2QmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.JSMVbU3VU0_aqxDx5e5hUDpMZlAqdS2ZZmqtjv2E6G8)
Can also install a Lua Script directly into mod manager as an easy way to enable or disable them.
When you install a script it will generate a mod.yml based on MetaData in the Lua or using defaults. The script will be copied to be in
mod/"chosen game"/scripts
which the Lua Engine configuration step in the setup wizard will set it so Lua Engine can load scripts from there. If you have Lua Engine installed either through Mod Manager or by selecting where you installed it and use Build and Run or Run only it will load the game and then load start Lua Engine.Taken from osdanovas PR to my fork.
![266825917-7eaac0ef-ba31-428d-9c83-8c068b5a1a1f](https://private-user-images.githubusercontent.com/47014056/266851404-46ea0b7c-0af0-475c-b24d-1df2d415f2ac.gif?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg5MTAzMzIsIm5iZiI6MTczODkxMDAzMiwicGF0aCI6Ii80NzAxNDA1Ni8yNjY4NTE0MDQtNDZlYTBiN2MtMGFmMC00NzVjLWIyNGQtMWRmMmQ0MTVmMmFjLmdpZj9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA3VDA2MzM1MlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTAxODk4NTQ2NDcyOWQyNTY1YjQ4NGVlMjQ0YjIwYmZjYjM0ZTg2MjY1MDlhNTEwOGNjNzliMzc4YmNiMDZjZjkmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.YmhD_XhC_Bg8xvubPhpYbcWFMelV7e0rrJds4Bn43Xg)
Changes the presets to its own menu. Backend remains mostly the same.