Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding OpenKh.Tools.Kh2FontImageEditor #847

Draft
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

kenjiuno
Copy link
Collaborator

@kenjiuno kenjiuno commented Aug 7, 2023

About

Editor of both fontimage.bar and fontinfo.bar.

Initial

2023-11-19_00h43_29

FontJapanese

2023-11-19_00h49_20

Spacing editor

2023-11-19_01h57_56

Unresolved issues

Alpha value ranging of Icon

The one big problem is that color palette of Icon image.
This is an Indexed8 image so we can edit the palette too.
But the alpha channel (Ps2 alpha) of the palette has irregular rule that we had not before.
0 to 128 is mapped to 0 to 255 (0.0 to 1.0) in PC.
129 to 255 is what for? This is for brighter alpha color blending (1.0 to 2.0).
We need good sense and good idea and valid data format to support this overkill usage of alpha channel of color palette for import and export purpose.

Untested for non FontJapanese

@kenjiuno

This comment was marked as outdated.

@Vladabdf
Copy link
Collaborator

Vladabdf commented Aug 8, 2023

This could be an error on my part (it's been a long time now since I've patched, tested, and used the PS2 version of the game for modifications and testing OpenKH tools), however upon patching the game with an edited fontimage.bar file using this tool, this is the end result.
image

I will include the fontimage in question as well.
fontimage.zip

I have yet to test using the OpenKH mod manager method, though I am unsure that would change the result. This methodology of testing I have done is using the legacy, far outdated patching method.

@Vladabdf
Copy link
Collaborator

Vladabdf commented Aug 8, 2023

...this is the end result.

Ah, this would be why. It looks like upon importing my edited fontimage png, the program flipped the color channels for all three tables present? Or perhaps an indexing issue...
image

@kenjiuno kenjiuno marked this pull request as draft October 22, 2023 12:26
@kenjiuno
Copy link
Collaborator Author

Hi I have rewritten some of this editor. Could you please re-test again.

@TopazTK
Copy link
Collaborator

TopazTK commented Jan 29, 2024

Bumping this for testing.

@Vladabdf
Copy link
Collaborator

I will test this soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants