Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement --position-scaling option to AnbMaker #754

Merged
merged 6 commits into from
Dec 22, 2023

Conversation

kenjiuno
Copy link
Collaborator

Overview

Mitigate chibi sora problem of 3D motion data built by AnbMaker.

Use --position-scaling 100 option or such.

OpenKh.Command.AnbMaker.exe anb-ex --help
fbx file: fbx to interpolated motion anb

Usage: OpenKh.Command.AnbMaker anb-ex [options] <InputModel> <Output>

Arguments:
  InputModel                                fbx input
  Output                                    anb output

Options:
  -?|-h|--help                              Show help information.
  -r|--root-name <ROOT_NAME>                specify root armature node name
  -m|--mesh-name <MESH_NAME>                specify mesh name to read bone data
  -a|--animation-name <ANIMATION_NAME>      specify animation name to read bone data
  -x|--node-scaling <NODE_SCALING>          apply scaling to each source node
                                            Default value is: 1.
  -p|--position-scaling <POSITION_SCALING>  apply scaling to bone position
                                            Default value is: 1.
  -w|--mset-file <MSET_FILE>                optionally inject new motion into mset directly
  -i|--mset-index <MSET_INDEX>              zero based target index of bar entry in mset file
                                            Default value is: 0.

Samples

Disclaimer: The sample screen shots listed below use Sora 3D model data in certain reason. However the target model is the following 3D model data.

2023-01-18_20h50_34

anb (raw)

without --position-scaling 100

OpenKh.Command.AnbMaker.exe anb H:\Dev\KH2\Mikote111\first_try.fbx H:\Dev\KH2\Mikote111\first_try.anb -w H:\Dev\KH2\Mikote111\first_try.mset

2023-01-18_20h47_40

with --position-scaling 100

OpenKh.Command.AnbMaker.exe anb H:\Dev\KH2\Mikote111\first_try.fbx H:\Dev\KH2\Mikote111\first_try.anb -w H:\Dev\KH2\Mikote111\first_try.mset --position-scaling 100

2023-01-18_20h47_00

anb (interpolated)

without --position-scaling 100

OpenKh.Command.AnbMaker.exe anb-ex H:\Dev\KH2\Mikote111\first_try.fbx H:\Dev\KH2\Mikote111\first_try.anb -w H:\Dev\KH2\Mikote111\first_try.mset

2023-01-18_20h48_44

with --position-scaling 100

OpenKh.Command.AnbMaker.exe anb-ex H:\Dev\KH2\Mikote111\first_try.fbx H:\Dev\KH2\Mikote111\first_try.anb -w H:\Dev\KH2\Mikote111\first_try.mset --position-scaling 100

2023-01-18_20h49_16

@kenjiuno kenjiuno marked this pull request as ready for review January 18, 2023 11:55
@kenjiuno
Copy link
Collaborator Author

Moving back to draft. need fix

@kenjiuno kenjiuno marked this pull request as draft January 18, 2023 12:24
@kenjiuno kenjiuno marked this pull request as ready for review November 7, 2023 17:38
@kenjiuno
Copy link
Collaborator Author

kenjiuno commented Nov 9, 2023

This will be ready 👍 perhaps

@kenjiuno kenjiuno merged commit 1e056e4 into OpenKH:master Dec 22, 2023
3 checks passed
@kenjiuno kenjiuno deleted the fix-chibi-sora-2 branch December 22, 2023 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants