Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Detect Install for Steam #1138

Merged
merged 4 commits into from
Jan 17, 2025
Merged

Better Detect Install for Steam #1138

merged 4 commits into from
Jan 17, 2025

Conversation

shananas
Copy link
Collaborator

@shananas shananas commented Jan 16, 2025

If the user had a folder with the same name as where 1.5 2.5 or 2.8 were installed it would say it is a valid install even if the folder is empty. this checks that .dll that lets you press the next button exists in that folder first.

If the user had a folder with the same name as where 1.5 2.5 or 2.8 were installed it would say it is a valid install even if the folder is empty. this checks that .dll that lets you press the next button exists in that folder first. EGS detect game install seems to be a little more specific and i do not have the EGS version to test so i did not edit that code.
@shananas
Copy link
Collaborator Author

Detect EGS install also checks for the .dll that lets the user press next. Untested since i dont own EGS version.
Just added an if statement to check for the dll in the found game path should work fine

@shananas
Copy link
Collaborator Author

Lua Backend code updates and crash prevention

@TopazTK
Copy link
Collaborator

TopazTK commented Jan 17, 2025

sonic-boom-knuckles

@shananas shananas merged commit 329b7ad into OpenKH:master Jan 17, 2025
3 checks passed
@Delta-473
Copy link
Collaborator

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants