Fix some YamlGenerator (ModsManager) inconvenience #1131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… yet` when trying to decode Japanese evt/sys messages.
- Remove redundant `await Task.Yield();`
- Valid file path to msg.yml is now set:
```
- name: msg/jp/sys.bar
method: binarc
source:
- name: sys
method: kh2msg
source:
- name: msg/jp/sys_sys.yml
language: jp
type: list
```
- Japanese evt messages are now set to `je` like `language: je`:
```
- name: msg/jp/al.bar
method: binarc
source:
- name: sys
method: kh2msg
source:
- name: msg/jp/al_al.yml
language: je
type: list
```
shananas
approved these changes
Dec 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix ModsManager crashes on startup when
mod.ymlis empty file.Fix Generator of YamlGenerator fails due to null error, if mod.yml is an empty file.
Fix error
System.NotImplementedException: Command 17 not implemented yetwhen trying to decode Japanese evt/sys messages.Fix problems of ProvideExtractorsService:
await Task.Yield();jelikelanguage: je: