Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added listpatch support for LVPM #1034

Closed
wants to merge 4 commits into from
Closed

Conversation

kareking1
Copy link
Contributor

Made Lvpm listpatchable. This solution should be applicable for all files that don't have an ID. Also had to include a new class in BaseTable to account for tables that only have 1 int as a header and not 2 ints...

Karekin added 2 commits May 7, 2024 14:58
…iles that don't have an ID. Also had to include a new class in BaseTable to account for tables that only have 1 int as a header and not 2 ints...
@kareking1
Copy link
Contributor Author

Correction: The new class is for when there is no header at all

Copy link
Collaborator

@shananas shananas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to write a test for this in OpenKh.Tests/Patcher/PatcherTests.cs
and write documentation in docs/tool/GUI.ModsManager/creatingMods.md

@kareking1
Copy link
Contributor Author

You also need to write a test for this in OpenKh.Tests/Patcher/PatcherTests.cs and write documentation in docs/tool/GUI.ModsManager/creatingMods.md

I added a working test and an entry to lvpm. Let me know if there's anything else

@shananas
Copy link
Collaborator

youll need to sync changes since your PR as your adding back a removed .yml and seemingly editing some submodules. hopefuly this also fixes the build error as its unrelated to your code changes.

@kareking1
Copy link
Contributor Author

youll need to sync changes since your PR as your adding back a removed .yml and seemingly editing some submodules. hopefuly this also fixes the build error as its unrelated to your code changes.

I'm not sure what to do about the submodules. I deleted the yml file, but I can't do anything about them... kinda just automatic. I can delete them using git rm, but idk if you want me to straight remove them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants