Dont allow special characters in credential names (#2909)

OpenFn · Feb 6, 2025 · 700c621 · 700c621
1 parent 2bbcccd
commit 700c621
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/lib/lightning/credentials/credential.ex b/lib/lightning/credentials/credential.ex
@@ -49,6 +49,9 @@ defmodule Lightning.Credentials.Credential do
     )
     |> assoc_constraint(:user)
     |> assoc_constraint(:oauth_client)
+    |> validate_format(:name, ~r/^[a-zA-Z0-9_\- ]*$/,
+      message: "credential name has invalid format"
+    )
     |> validate_oauth()
     |> validate_transfer_ownership()
   end

diff --git a/test/lightning_web/live/credential_live_test.exs b/test/lightning_web/live/credential_live_test.exs
@@ -299,6 +299,10 @@ defmodule LightningWeb.CredentialLiveTest do
              |> form("#credential-form-new", credential: %{name: ""})
              |> render_change() =~ "can&#39;t be blank"
 
+      assert index_live
+             |> form("#credential-form-new", credential: %{name: "MailChimp'24"})
+             |> render_change() =~ "credential name has invalid format"
+
       {:ok, _index_live, html} =
         index_live
         |> form("#credential-form-new", credential: @create_attrs)