Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DataClone Errors #873

Merged
merged 7 commits into from
Feb 13, 2025
Merged

Fix DataClone Errors #873

merged 7 commits into from
Feb 13, 2025

Conversation

josephjclark
Copy link
Collaborator

Short Description

This PR fixes an issue where exceptions thrown by Adaptors can include unserializable data (I'm looking at you, Axios), triggering a crash in the worker.

Fixes #871

Implementation Details

This is one of those that takes 2 days of head scratching and then a single line code diff.

This is the second fix and there are two things to note:

  1. The test to determine whether an error is an AdaptorError was too strict. This meant that in some cases (depending on what state the repo happens to be in) the runtime was wrongly deciding errors weren't from the adaptor. The upshot of this is that sometimes the DataCL=loneError does not occur (it did not occur locally or on staging while I was debugging).
  2. When an adaptorerror is created, we now force a call to fast-safe-stringify to ensure that it serializes safely. This prevents the data clone error occurring downstream.

AI Usage

Please disclose how you've used AI in this work (it's cool, we just want to know!):

  • Code generation (copilot but not intellisense)
  • Learning or fact checking
  • Strategy / design
  • Optimisation / refactoring
  • Translation / spellchecking / doc gen
  • Other
  • I have not used AI

@josephjclark josephjclark merged commit 50c42aa into main Feb 13, 2025
10 checks passed
@josephjclark josephjclark deleted the fix-dataclone-2 branch February 13, 2025 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Weird DataCloneError occuring on failed jobs
1 participant