Issue #962 - Implemented B22 test #1433
Conversation
|
The Conflict stems from the fact that the comments // Implement test B17 - B22 were wrapped in test B16. We had unwrapped the rest of the comments along side the B22 comment and completed B22. |
|
Thank you to @AAshGray @bellxalli @mlarsen-source for their work for not only implementing the test case as well as fixing the comment placement! All contributors have signed the CLA and the test case itself looks good. However there are a few changes that we ask be made. |
| @@ -174,7 +175,78 @@ mocha.describe('readings API', () => { | |||
| // Add B21 here | |||
|
|
|||
| // Add B22 here | |||
There was a problem hiding this comment.
Please remove the comment of your test case
| @@ -174,7 +175,78 @@ mocha.describe('readings API', () => { | |||
| // Add B21 here | |||
|
|
|||
| // Add B22 here | |||
| }); | |||
|
|
|||
There was a problem hiding this comment.
Please delete the lines between the function and the comment for B21. Leave just one between the comment and your test case.
|
The styling has been updated so it now says: // Add B20 here // Add B21 here [code code code] It should be up to standard now. Let us know if anything else needs adjustment! |
Description
B22 test implemented and passes. Added expected data for B22.
Collaborators:
@AAshGray
@bellxalli
@mlarsen-source
Partly addresses issue #962
Type of change
(Check the ones that apply by placing an "x" instead of the space in the [ ] so it becomes [x])
Checklist
(Note what you have done by placing an "x" instead of the space in the [ ] so it becomes [x]. It is hoped you do all of them.)
Limitations
(Describe any issues that remain or work that should still be done.)