Final test C10 #1431
Final test C10 #1431
Conversation
Co-authored by: Caden Carpenter <[email protected]> Co-authored by: Anthony Theng <[email protected]>
|
Hello, it appears you marked that the database is changed with this commit as well as the documentation needs an update with this merge. Can you confirm if this is the case? Furthermore, can you add your group mates using their github usernames via @[username]? I don't believe anyone has signed the CLA, please have everyone in the group do that. For @huss, please edit the PR to change Fixes #[962] to Partially Addresses #962. |
|
Hi, I don't believe our commit will change the database or require updated documentation. I'll edit the PR to add their usernames and make sure my group signs the CLA. |
|
All of the students have signed the CLA and everything in the code looks good. |
There was a problem hiding this comment.
Thanks to @heleeon, @CadenC63 & @anthonytheng for their first contribution to OED. I have a few comment to address. Please let me know if anything is not clear.
| mocha.it('C10: 1 day shift end 2022-10-31 17:00:00 for 15 minute reading intervals and quantity units & kWh as BTU', async () => { | ||
| // Use predefined unit and conversion data | ||
| const unitData = unitDatakWh.concat([ | ||
| //adding u1, u2, u3, u16 |
There was a problem hiding this comment.
u1 & u2 are defined in unitDataKWh and should not be redefined here. u3 & u16 should be concat here to define. The test case is failing on my machine and this is the reason why.
| // Use predefined unit and conversion data | ||
| const unitData = unitDatakWh.concat([ | ||
| //adding u1, u2, u3, u16 | ||
| { //u1 |
There was a problem hiding this comment.
OED prefers not to have comments at the end of the line. Could you move these (this one will be removed but for later ones) to the next line above the code being described.
| } | ||
| ]); | ||
| const conversionData = conversionDatakWh.concat([ | ||
| // adding c1, c2, c3 |
There was a problem hiding this comment.
As with units, c1 is already defined and should not be added here.
Co-authored by: Caden Carpenter [email protected] @CadenC63
Co-authored by: Anthony Theng [email protected] @anthonytheng
Description
This pull request aims to allow testcase C10 to run alongside the other quantity meter tests.
It ensures that the Electric_Utility unit (BTU) is correctly correctly compared when read. The reading requested is in BTU.
This was accomplished through the specifications outlined in the DesignDocs
Partly addresses #962
(In general, OED likes to have at least one issue associated with each pull request. Replace [issue] with the OED GitHub issue number. In the preview you will see an issue description if you hover over that number. You can create one yourself before doing this pull request. This is where details are normally given on what is being addressed. Note you should not use the word "Fixes" if it does not completely address the issue since the issue would automatically be closed on merging the pull request. In that case use "Partly Addresses #[issue].)
Type of change
(Check the ones that apply by placing an "x" instead of the space in the [ ] so it becomes [x])
Checklist
(Note what you have done by placing an "x" instead of the space in the [ ] so it becomes [x]. It is hoped you do all of them.)
Limitations
No limitations we were made aware of.