-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default meter select #1348
Default meter select #1348
Conversation
…ted should be shown as selected by default, without the user needing to click it.
…pplies to not only meter but also group
The code looks good, and very clear wit the functionality. it works and I'm personally not familiar with the nuances of react to determine if there is a better solution. |
Everything looks good to me. Please convert this draft to PR. |
This is a note to be sure that PR #1314 does similar logic/effect or to get them in sync. This does not directly impact this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks to @nneni for another contribution. Review found it works as expected. I have made a couple of small comments to address.
Thanks for catching those! Just made the edits and pushed them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks to @nneni for addressing the comments. Review and testing found it addressed them all correctly. Congratulations on another accepted contribution.
Description
Fixes #1186
Utilized React's useEffect hook to manage which option is selected when there is only one option (the only available choice, by default).
Type of change
Checklist
Limitations
None, at first the code was too specific and only applied to one of the data categories but after reanalysis it was rewritten to work in a more general sense.