Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added test description files for all tests currently present in functional_test_frame_work #1

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

beauof
Copy link

@beauof beauof commented Feb 28, 2018

functional_test_frame_work needs test description files

issue #2

@hsorby
Copy link
Contributor

hsorby commented Mar 2, 2018

When I used the functional test framework with the proposed database I had 21 tests fail out of 37. We only want to add tests that pass and to keep those tests passing when changes are introduced into the database.

These tests failed:

	  1 - active_contraction (Failed)
	  6 - pycantilever (Failed)
	  7 - pycantilever_growth (Failed)
	  8 - pycellml_growth_law (Failed)
	  9 - cellml_split_reaction_diffusion_equation (Failed)
	 13 - pydof_constraints (Failed)
	 14 - pyfsi_2d_obstacle (Failed)
	 15 - pyfsi_tube_flow (Failed)
	 16 - pyhermite_prolate_spheroid_mechanics (Failed)
	 17 - pyhomogeneous_pipe_axial_extension (Failed)
	 19 - pylaplace_equation (Failed)
	 20 - pyleft_ventricle_inflation (Failed)
	 23 - pymonodomain_2D_HH (Failed)
	 24 - pymonodomain_2D_vary_parameters_spatially (Failed)
	 25 - mooney_rivlin_cellml (Failed)
	 26 - pynavierstokes_coupled1d0d (Failed)
	 27 - pynavierstokes_liddrivencavity (Failed)
	 28 - pynavierstokes_poiseuilleflow (Failed)
	 30 - poiseuille_static (Failed)
	 33 - stokes_ale (Failed)
	 37 - pyuniaxial_extension (Failed)

and shouldn't be added at this time.

@beauof
Copy link
Author

beauof commented Mar 2, 2018

There are 2 tests that actually fail, because the FSI code is currently being merged in by @chrispbradley and should be available soon.

For the rest of the failed tests that you are seeing, there are two answers:

  1. The Python tests fail if the Python bindings for OpenCMISS-iron are not created correctly.
  2. The other tests fail because input files are not found. Here I would propose having an additional data base for all input files, such as meshes, xml, cellml files, etc. See OpenCMISS/functional_test_framework#4

@hsorby
Copy link
Contributor

hsorby commented Mar 2, 2018

I have modified the OpenCMISS-Examples/active_contraction codebase to accept arguments (in a PR at the time of writing). This change enables the example to successfully pass the functional test frameworks testing criteria.

Enabling the examples that cannot accept arguments for input files is the first step in adapting the examples that fail due to input files not being accessible.

@hsorby
Copy link
Contributor

hsorby commented Mar 2, 2018

The reason for the failing Python tests is a concern. I don't quite understand how the Python bindings for Iron are not created correctly. That seems like quite a serious problem if it is the case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants