Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Facederivatives #190

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

chrispbradley
Copy link
Member

Fixing face derivative calculations for collapsed elements. The previous face calculations only worked for tricubic-Hermite elements. Some examples, e.g. linear Lagrange-bicubic Hermite, will change as things are now done correctly. Fixed exporting of sector elements. The code no longer crashes but it still doesn't produce .ex files that can be read into cmgui.

@@ -291,8 +294,17 @@ static int FieldExport_File_InterpolationHeader( FileSession *const session, con
{
if( labelType == FIELD_IO_INTERPOLATION_HEADER_GRID )
{
scaleFactorCount *= 2;
label = "l.Lagrange";
scaleFactorCount *= 2;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some tabs here and in a few other places in this file that mess up the indentation in my editor.

@adamreeve
Copy link
Contributor

I tried running the tests and I get an error with many examples (eg. FiniteElasticity/UniAxialExtension/Fortran) in MeshTopologyFinalise at DEALLOCATE(mesh%topology(componentIdx)%ptr): Attempt to DEALLOCATE unallocated 'mesh'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants