Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix menu button height when zoomed out #1785

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Fix menu button height when zoomed out #1785

merged 1 commit into from
Dec 20, 2024

Conversation

ryan-pratt
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.58%. Comparing base (620b543) to head (fcae664).
Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1785      +/-   ##
==========================================
+ Coverage   79.56%   79.58%   +0.01%     
==========================================
  Files         517      517              
  Lines       40737    40737              
==========================================
+ Hits        32414    32420       +6     
+ Misses       8323     8317       -6     
Flag Coverage Δ
python 84.30% <ø> (+0.04%) ⬆️
ruby-api 48.64% <ø> (ø)
ruby-backend 82.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jmthomas jmthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add relevant screenshots for stuff like this. It's a little more work but it really helps with review!

@ryan-pratt
Copy link
Contributor Author

Before (zoom level <100%):
image

After:
image

@ryan-pratt ryan-pratt merged commit 34889a4 into main Dec 20, 2024
28 checks passed
@ryan-pratt ryan-pratt deleted the menu-button-icon branch December 20, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants