Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further SOMD1 compatibility updates #26

Merged
merged 4 commits into from
Mar 11, 2024
Merged

Conversation

lohedges
Copy link
Contributor

@lohedges lohedges commented Mar 8, 2024

This PR adds the following minor updates for SOMD1 compatibility and testing:

  • Check for light atoms in perturbable molecules by the maximum end-state mass only.

  • Check that the constraints are the same in both end states and log a message if not.

  • I also added a missing constraint kwarg to the minimisation.

@lohedges lohedges requested a review from mb2055 March 8, 2024 14:52
@lohedges
Copy link
Contributor Author

lohedges commented Mar 8, 2024

These fixes require the fix_constraints branch of sire.

@chryswoods
Copy link

I'm happy to merge fix_constraints in if you want? I left it until we were happy we'd fixed most of the bugs.

@lohedges
Copy link
Contributor Author

lohedges commented Mar 8, 2024

Yes, no problem. I assumed that I'd figure out the rest of the problem quickly and add to the branch. Alas.

@lohedges
Copy link
Contributor Author

I've added a few further tweaks:

  • End-state constraints are now checked for all perturbable molecules in the system.
  • Make sure that pressure can be disabled from the command-line, i.e. add special handling for the case of "None" .
  • Exposed the barostat_frequency kwarg via the Config class.

Copy link
Contributor

@mb2055 mb2055 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 all working on my end

@lohedges lohedges merged commit e2e7a97 into main Mar 11, 2024
6 checks passed
@lohedges lohedges deleted the feature_somd1_compatibility2 branch March 11, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants