[backend] Enforce delete injector contract #2191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoinemzs
approved these changes
Jan 10, 2025
openbas-api/src/main/java/io/openbas/rest/injector_contract/InjectorContractService.java
Show resolved
Hide resolved
Comment on lines
-13
to
-33
|
|
||
| export const searchInjectors = (paginationInput) => { | ||
| const data = paginationInput; | ||
| const uri = '/api/injectors/search'; | ||
| return simplePostCall(uri, data); | ||
| }; | ||
|
|
||
| export const updateInjector = (injectorId, data) => (dispatch) => { | ||
| const uri = `/api/injectors/${injectorId}`; | ||
| return putReferential(schema.injector, uri, data)(dispatch); | ||
| }; | ||
|
|
||
| export const addInjector = data => (dispatch) => { | ||
| const uri = '/api/injectors'; | ||
| return postReferential(schema.injector, uri, data)(dispatch); | ||
| }; | ||
|
|
||
| export const deleteInjector = injectorId => (dispatch) => { | ||
| const uri = `/api/injectors/${injectorId}`; | ||
| return delReferential(uri, 'injectors', injectorId)(dispatch); | ||
| }; |
There was a problem hiding this comment.
Question: was all this unused?
There was a problem hiding this comment.
I don't know why this code was created at first.
We can't do anything on injector from the UI.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/1.11.0 #2191 +/- ##
====================================================
+ Coverage 32.46% 32.71% +0.24%
- Complexity 1511 1549 +38
====================================================
Files 582 583 +1
Lines 18091 18482 +391
Branches 1164 1217 +53
====================================================
+ Hits 5874 6046 +172
- Misses 11953 12171 +218
- Partials 264 265 +1 ☔ View full report in Codecov by Sentry. |
savacano28
reviewed
Jan 10, 2025
openbas-api/src/main/java/io/openbas/rest/injector_contract/InjectorContractService.java
Show resolved
Hide resolved
RomuDeuxfois
force-pushed
the
improvment/enforce-delete-injector-contract
branch
from
c16c8df to
12def24
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.